aldelaro5 / dolphin-memory-engine

A RAM search made specifically to search, monitor and edit the Dolphin emulator's emulated memory
MIT License
171 stars 39 forks source link

Remove remnants of the deactivated sorting mechanism. #144

Closed cristian64 closed 6 months ago

cristian64 commented 6 months ago

This sorting mechanism was deactivated in 65bb529fbd6f52ac547e, but the actual functionality was still in the code base.

Note that sorting was disabled due to its implementation being destructive: the actual watch nodes were reordered; not just the visual representation of the items in the Qt tree view. If the functionality is reinstated in the future, a QSortFilterProxyModel should be used.

dreamsyntax commented 6 months ago

We probably wont ever want this feature, but a search filter that doesnt destroy the dmw struct could be cool.