aldelaro5 / dolphin-memory-engine

A RAM search made specifically to search, monitor and edit the Dolphin emulator's emulated memory
MIT License
158 stars 36 forks source link

Prompt user before destructive operations of great impact. #147

Closed cristian64 closed 1 month ago

cristian64 commented 1 month ago

The Clear the watch list action did not always show a confirmation dialog, only when there were unsaved changes, which overlooked the case where the watch list is only backed up by the data stored in the settings file.

dreamsyntax commented 1 month ago

I dislike having a prompt for Cut.

If we want this it should be a configurable Option state that can be enabled/disabled

"Confirm Cut" or "Confirm on Cut" etc as the name

aldelaro5 commented 1 month ago

Yeah I am not a big fan of confirm on cut either.

For clear list, it's reasonable (maybe it can offer a save before, but I am fine either way). It's just cut is one that you may do very frequently enough.

cristian64 commented 1 month ago

Yeah I am not a big fan of confirm on cut either.

For clear list, it's reasonable (maybe it can offer a save before, but I am fine either way). It's just cut is one that you may do very frequently enough.

I guess the data is still in the clipboard, so no need to bother the user when cutting.

dreamsyntax commented 1 month ago

Yeah I am not a big fan of confirm on cut either.

For clear list, it's reasonable (maybe it can offer a save before, but I am fine either way). It's just cut is one that you may do very frequently enough.

I guess the data is still in the clipboard, so no need to bother the user when cutting.

Just an additional data point most modern OS/DE ship clipboard history by default now too, so id be fine not having that feature at all.

cristian64 commented 1 month ago

I've now dropped the changes for the cut action.