Add options to copy pointer addresses (or base address) of a watch entry

aldelaro5 / dolphin-memory-engine

A RAM search made specifically to search, monitor and edit the Dolphin emulator's emulated memory

MIT License

171 stars 39 forks source link

Add options to copy pointer addresses (or base address) of a watch entry #167

Closed jahorta closed 4 months ago

jahorta commented 4 months ago

Added two methods for copying a pointer address to the clipboard

Added a context menu to the Edit Address widget for the pointer widget to copy an address from the address label
Added an option ("Copy address") to the context menu of a Memory Watch widget to copy either the base address of the memory watch, or a selected pointer level if the watch is a pointer.

The second item is currently located after the "Copy" entry of the context menu, though it might fit better after the "Browse memory at" entry.

reference: #160

dreamsyntax commented 4 months ago

I'll be doing real-world use / tests of this feature branch later ~~today~~. Is this otherwise ready for final review / merge? If it is, please mark it as non-draft with "Ready for review" button.

dreamsyntax commented 4 months ago

Tested on Windows.

Works great, thanks. I definitely prefer the right click feature in "Edit Watch" after having experimented with both, but there's no reason to remove the other context menu. It may suit other user preferences.

cristian64 commented 4 months ago

Not tested, but looks good to me.

cristian64 commented 4 months ago

As long as @cristian64 signs off on this, I'm good with merging as is. Since we are not super strict about squash/merge rules, I'll leave it up to you if you want to squash @cristian64

We should definitely squash this into a single commit.