search

aldelaro5 / ghidra-gekko-broadway-lang

Ghidra language definition for the Gekko and Broadway CPU variant used in the Nintendo GameCube and Nintendo Wii respectively
Other
127 stars 16 forks source link

dequantize still shows up after setting GQR0 #2

Open magcius opened 4 years ago

magcius commented 4 years ago

image

aldelaro5 commented 4 years ago

Just to inform: I will check this once I come back to be active on gc/wii reversing which I plan for Q1 2020.

aboood40091 commented 3 years ago

Any update on this? For me, it results in many checks for variables that already have a fixed value at the top of the function and many "if (true)" and "if (false)" that make the code very bloated and ugly.

Example: unknown (4)

All the code in red is useless.

magcius commented 3 years ago

I recommend using this fork https://github.com/beholdnec/ghidra-gekko-broadway-lang/tree/pairedsingle-fixes

On Sat, Jun 19, 2021, 5:24 AM AboodXD @.***> wrote:

Any update on this? For me, it results in many checks for variables that already have a fixed value at the top of the function and many "if (true)" and "if (false)" that make the code very bloated and ugly.

Example: [image: unknown (4)] https://user-images.githubusercontent.com/10743814/122642280-ae62d680-d11a-11eb-936e-40d6e0f7e8f0.png

All the code in red is useless.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/aldelaro5/ghidra-gekko-broadway-lang/issues/2#issuecomment-864399518, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAJ7OTODFEPXO6SD5QGIDDTTSD63ANCNFSM4JRDHFNQ .

aboood40091 commented 3 years ago

Thanks! It's much cleaner than before. I do still end up with few "if (false)" and "if (true)" but I guess I could live with them. image image

I guess they exist because of the W in psq_l frD, d(rA), W, I, but I'm curious why it can't optimize that away.