search

aldentantan / pe

0 stars 0 forks source link

Different error messages for client index greater than list index and client index = 0 #12

Open aldentantan opened 4 days ago

aldentantan commented 4 days ago

image.png

image.png

Given that both the client indexes of 0 and 10 are invalid in the above scenario, the error messages of entering both commands should be the same for both. However, cdelete 0 shows an error message of invalid command format, suggesting that there is an incorrect syntax error with the command, but it is actually due to the invalid index provided.

The error message for client index <= 0 and client index > list index should be the same to make it clearer to the user upon invalid command input.

soc-se-bot commented 1 day ago

Team's Response

We will accept this bug as severity.VeryLow, because it does not hinder the user from using the application, as it stops the user from performing an action on any invalid indexes.

image.png

Items for the Tester to Verify

:question: Issue type

Team chose [type.FeatureFlaw] Originally [type.FunctionalityBug]

Reason for disagreement: [replace this with your explanation]

## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Low`] - [x] I disagree **Reason for disagreement:** ![image.png](https://raw.githubusercontent.com/aldentantan/pe/main/files/b578bec9-60ef-4e0b-8235-33fc80ac22cb.png) I disagree with the labelling of this bug as VeryLow as it is not a purely cosmetic bug, but it affects the user experience and understanding of incorrect commands. By having 2 different error messages when the index of `cdelete` is above the valid range or below the valid range, the user may interpret these error messages differently. For example, if a user enters `cdelete 0`, the error message `Invalid command format` is shown, which the user may interpret as an incorrect command syntax or spelling of the command word, rather than the index provided being out of the valid range. However, when the user enters `cdelete 300`, assuming the list of contacts is less than 300 contacts long, the error message is `The client index provided is invalid`. This message is much clearer to the user that the issue lies in the index provided and they will know to rectify the invalid index they provided in order to provide a valid command. Thus, I am arguing that this bug should be of Low severity rather than VeryLow due to this difference in user experience, where it may inconvenience users occasionally.