search

aldenwalker / scallop

Stable commutator length computer
5 stars 1 forks source link

Fix makefiles for Mac OS M1 #2

Open dannycalegari opened 8 months ago

dannycalegari commented 8 months ago

This branch has makefile changes for M1, if you want to incorporate them. Also, if you know a better way to add the -target to the files, let me know and I'll make the changes and push them up.

Meg

dannycalegari commented 8 months ago

Btw, we were just setting up with glpk and gmp on Danny's laptop, we haven't gotten to setup for Gurobi yet.

aldenwalker commented 8 months ago

Awesome! I guess I'm wondering, does it really need the -targets? Doesn't it know to compile for the thing it's running on? (It seems like putting them in would mess up the build everywhere else?) Also, does it need a linker flag for ${CONDA_PREFIX}/lib? I guess not, since it worked! Also, sorry for what is a bit haphazard conglomeration of multiple projects into one blob and old makefiles. I'm a fan of out of tree builds and cmake now. Well, as much as anyone can be a fan of any build system.