aldinokemal / go-whatsapp-web-multidevice

API for Whatsapp Web Multi Device Version, Support UI & Webhook
MIT License
582 stars 245 forks source link

📖 REST API documentation consistency improvements #148

Closed alexvuka1 closed 5 months ago

alexvuka1 commented 5 months ago

What happened?

I have identified the following possible instances of inconsistencies between Open API specification and Documentation:

About

This is part of the evaluation of my Master's Project at Imperial College London. The section above is automatically generated and aims to expose API documentation inconsistencies in real-world GitHub repositories. The end goal is for the tool to be used as part of CI/CD, namely as a GitHub action.

Hopefully, this is a step towards easier maintenance of API documentation. If you find this helpful, please consider updating the documentation to keep it in sync with the source code. I am also happy to assist with it, if appropriate. If this has not been useful, consider updating this issue with an explanation, so I can improve my approach. Thank you!

Application Version

4.13.0

Verification

aldinokemal commented 5 months ago

@alexvuka1 I think you can check in Readme that promote, demote, etc. haven't been released yet.

alexvuka1 commented 5 months ago

Thank you for the prompt response and for pointing out the false positives.

The tool currently flags any discrepancies between the documented endpoints and the Open API specification to ensure consistency. However, I realise this can include endpoints that are pending release, such as in your case. To improve the tool's accuracy, it would be useful to incorporate a way to identify and exclude such pre-release features from the checks.

Another approach that I can think of is to add the endpoints to the Open API specification but mark them as not implemented. That would also resolve the inconsistencies. It would be interesting to hear your thoughts on that.

Other than that, it flagged 3 more inconsistencies, are those valid?

Thank you again for your cooperation and understanding!