search

aldoborrero / k8s-usenet

k8s-usenet is a collection of Helm charts related to Usenet services.
Apache License 2.0
77 stars 14 forks source link

ServicePort != ContainerPort #4

Open MansM opened 4 years ago

MansM commented 4 years ago

When trying to put lidarr on port 80 (as I am using metallb and dont like to add ports in the address bar) I encountered that the helm chart puts the service ports also on the container port:

https://github.com/aldoborrero/k8s-usenet/blob/3a56b740ddde00ed237c8073cf6e86a75146dd40/lidarr/templates/deployment.yaml#L37

Not sure if this is for all charts... Can you separate those?

aldoborrero commented 4 years ago

Hey @MansM yeah we can make a separate entry (if you want prepare a PR where we correct this). Otherwise I'll do it over the weekend.

Thanks