Not buildable with gcc-14

[gvanuxem]

See title. It is a well known issue for a lot of projects. GCC-14 is more rigorous with implicit cast.

  JAVAC    foamlib.classlib
  JAR    foamlib.jar
cp _sublib_foamlib.al libfoamlib.al
make[4] : on quitte le répertoire « /home/greg/Git/aldor/aldor/aldor/lib/libfoamlib/al »
make[4] : on entre dans le répertoire « /home/greg/Git/aldor/aldor/aldor/lib/libfoamlib »
  CC       al/array.o
  CC       al/basic.o
al/basic.c: In function ‘CF35_error’:
al/basic.c:1210:15: error: passing argument 1 of ‘fputs’ makes pointer from integer without a cast [-Wint-conversion]
 1210 |         fputs(P0_s, stdoutFile());
      |               ^~~~
      |               |
      |               FiWord {aka long unsigned int}
al/basic.c:301:12: note: expected ‘const char *’ but argument is of type ‘FiWord’ {aka ‘long unsigned int’}
  301 | extern int fputs(); /* Signature patched in ccode.c:ccoPr */
      |            ^~~~~
al/basic.c:1210:21: error: passing argument 2 of ‘fputs’ makes pointer from integer without a cast [-Wint-conversion]
 1210 |         fputs(P0_s, stdoutFile());
      |                     ^~~~~~~~~~~~
      |                     |
      |                     FiWord {aka long unsigned int}
al/basic.c:301:12: note: expected ‘void *’ but argument is of type ‘FiWord’ {aka ‘long unsigned int’}
  301 | extern int fputs(); /* Signature patched in ccode.c:ccoPr */
      |            ^~~~~
al/basic.c:1211:15: warning: ‘fputc’ argument 1 type is ‘long unsigned int’ where ‘int’ is expected in a call to built-in function declared without prototype [-Wbuiltin-declaration-mismatch]
 1211 |         fputc((FiWord) 10L, stdoutFile());
      |               ^~~~~~~~~~~~
al/basic.c:300:12: note: built-in ‘fputc’ declared here
  300 | extern int fputc(); /* Signature patched in ccode.c:ccoPr */
      |            ^~~~~
al/basic.c:1211:29: error: passing argument 2 of ‘fputc’ makes pointer from integer without a cast [-Wint-conversion]
 1211 |         fputc((FiWord) 10L, stdoutFile());
      |                             ^~~~~~~~~~~~
      |                             |
      |                             FiWord {aka long unsigned int}
al/basic.c:300:12: note: expected ‘void *’ but argument is of type ‘FiWord’ {aka ‘long unsigned int’}
  300 | extern int fputc(); /* Signature patched in ccode.c:ccoPr */
      |            ^~~~~
al/basic.c: In function ‘CF72__LT__LT_’:
al/basic.c:2079:15: error: passing argument 1 of ‘fputs’ makes pointer from integer without a cast [-Wint-conversion]
 2079 |         fputs((FiWord) "Unknown mode", stdoutFile());
      |               ^~~~~~~~~~~~~~~~~~~~~~~
      |               |
      |               long unsigned int
al/basic.c:301:12: note: expected ‘const char *’ but argument is of type ‘long unsigned int’
  301 | extern int fputs(); /* Signature patched in ccode.c:ccoPr */
      |            ^~~~~
al/basic.c:2079:40: error: passing argument 2 of ‘fputs’ makes pointer from integer without a cast [-Wint-conversion]
 2079 |         fputs((FiWord) "Unknown mode", stdoutFile());
      |                                        ^~~~~~~~~~~~
      |                                        |
      |                                        FiWord {aka long unsigned int}
al/basic.c:301:12: note: expected ‘void *’ but argument is of type ‘FiWord’ {aka ‘long unsigned int’}
  301 | extern int fputs(); /* Signature patched in ccode.c:ccoPr */
      |            ^~~~~
al/basic.c:2080:15: warning: ‘fputc’ argument 1 type is ‘long unsigned int’ where ‘int’ is expected in a call to built-in function declared without prototype [-Wbuiltin-declaration-mismatch]
 2080 |         fputc((FiWord) 10L, stdoutFile());
      |               ^~~~~~~~~~~~
al/basic.c:300:12: note: built-in ‘fputc’ declared here
  300 | extern int fputc(); /* Signature patched in ccode.c:ccoPr */
      |            ^~~~~
al/basic.c:2080:29: error: passing argument 2 of ‘fputc’ makes pointer from integer without a cast [-Wint-conversion]
 2080 |         fputc((FiWord) 10L, stdoutFile());
      |                             ^~~~~~~~~~~~
      |                             |
      |                             FiWord {aka long unsigned int}
al/basic.c:300:12: note: expected ‘void *’ but argument is of type ‘FiWord’ {aka ‘long unsigned int’}
  300 | extern int fputc(); /* Signature patched in ccode.c:ccoPr */
      |            ^~~~~
make[4]: *** [Makefile:515 : al/basic.o] Erreur 1
make[4] : on quitte le répertoire « /home/greg/Git/aldor/aldor/aldor/lib/libfoamlib »
make[3]: *** [Makefile:551 : all-recursive] Erreur 1
make[3] : on quitte le répertoire « /home/greg/Git/aldor/aldor/aldor/lib/libfoamlib »
make[2]: *** [Makefile:377 : all-recursive] Erreur 1
make[2] : on quitte le répertoire « /home/greg/Git/aldor/aldor/aldor/lib »
make[1]: *** [Makefile:380 : all-recursive] Erreur 1
make[1] : on quitte le répertoire « /home/greg/Git/aldor/aldor/aldor »
make: *** [Makefile:603 : all-recursive] Erreur 1

[gvanuxem]

I forgot, it is buildable with gcc-13 or gcc-12 after, for example, a simple:

export CC=gcc-13
./configure && make

┌──(greg㉿ellipse)-[~/Git/aldor/aldor] └─$ gcc-13 --version gcc-13 (Debian 13.3.0-8) 13.3.0 Copyright (C) 2023 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

┌──(greg㉿ellipse)-[~/Git/aldor/aldor] └─$ gcc-14 --version gcc-14 (Debian 14.2.0-6) 14.2.0 Copyright (C) 2024 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

[pbroadbery]

I expect that adding "CFLAGS=-Wno-error=int-conversion" will fix it, and if not, adding the same to strict_compile.m4 will do the job. I'll look into the cause to see if there's a better fix later.

[gvanuxem]

I expect that adding "CFLAGS=-Wno-error=int-conversion" will fix it, and if not, adding the same to strict_compile.m4 will do the job. I'll look into the cause to see if there's a better fix later.

The two work around the conversion to int issues but, after, the build process shocks on:

make[4] : on entre dans le répertoire « /home/greg/Git/aldor/aldor/lib/axllib/src »
  CC       al/array.o
al/array.c: In function ‘CF34_convert’:
al/array.c:2061:16: error: returning ‘char **’ from a function with incompatible return type ‘FiPtr’ {aka ‘char *’} [-Wincompatible-pointer-types]
 2061 | L1:     return T1;
      |                ^~
al/array.c: In function ‘CF37_flatten’:
al/array.c:2191:16: error: returning ‘char **’ from a function with incompatible return type ‘FiPtr’ {aka ‘char *’} [-Wincompatible-pointer-types]
 2191 | L4:     return T10;

Here is the make log after your suggestions:

make.log.gz

[pbroadbery]

OK, adding "-Wno-error=incompatible-pointer-types" will fix that..

If the build still fails, then running "make -k" will push the build a bit further.

If that then fails, then run configure with "--enable-error-on-warning=no". This will mean that warnings are not treated as errrors.

[gvanuxem]

"-Wno-error=incompatible-pointer-types" is nt supported by gcc but "-Wincompatible-pointer-types" is (transform them on warning only). So, the build was successful. But as with gcc-13 not all the tests passed and aldor support for FriCAS, for example, is not functional. The FriCAS build shocks on cliques.as from memory. I attached the two logs related to Aldor:

check.log.gz make2.log.gz

[pbroadbery]

What's the error with cliques.as?

The file should probably be included in the aldor build as a test. Something to do for later.

Follow up questions - what architecture are you building on, and do you have the output from running configure?

[gvanuxem]

I finally managed to find appropriate flags, I was wrong, I still had an exported CFLAGS set to -fpermissive. From the man page:

       -fpermissive
           Downgrade  some  required  diagnostics  about  nonconformant  code  from  errors  to  warnings.  Thus, using
           -fpermissive allows some nonconforming code to compile.  Some C++ diagnostics are controlled  only  by  this
           flag, but it also downgrades some C and C++ diagnostics that have their own flag:

           -Wdeclaration-missing-parameter-type   (C  and  Objective-C  only)  -Wimplicit-function-declaration  (C  and
           Objective-C only) -Wimplicit-int (C and Objective-C only) -Wincompatible-pointer-types  (C  and  Objective-C
           only)  -Wint-conversion  (C and Objective-C only) -Wnarrowing (C++ and Objective-C++ only) -Wreturn-mismatch
           (C and Objective-C only)

           The -fpermissive option is the default for  historic  C  language  modes  (-std=c89,  -std=gnu89,  -std=c90,
           -std=gnu90).

And, I was modifying a bad part of the m4 file m4/strict_compile.m4 line 21: cfgSTRICTCFLAGS="${cfgSTRICTCFLAGS} -Wno-error=clobbered" But this had no effect. The only way I found is exporting CFLAGS like this before the configure step: export CFLAGS='-Wno-incompatible-pointer-types -Wno-int-conversion' and the build was successful.

The problem which remains to me is cliques.as, again fput* issues. The Makefile has a special rule for it:

# The program 'cliques' computes cliques according to the dependencies from
# the gendeps directory. It writes a collection of Makefile variable
# assignments and Makefile targets to stdout.
CLIQUEOPTS=-mno-abbrev -mno-mactext -laldor -fx -c args=-lm
cliques: cliques.as
#   $(ALDOR) $(CLIQUEOPTS) $<
    $(ALDOR) $(CLIQUEOPTS) -dTRACE $<

But since the CFLAGS was not used I had to re-link gcc to gcc-13 to build it and have a working FriCAS with Aldor support. By the way, after, FriCAS compiles files using Aldor to lisp file and (compile-file ...) them so it does not matter a lot.

I also noticed that the path to unicl is hardcoded from ./configure --prefix=... so if you move the directory in which aldor was installed you break your aldor installation.

Hope that helps