search

aldostools / webMAN-MOD

Extended services for PS3 console (web server, ftp server, netiso, ntfs, ps3mapi, etc.)
https://aldostools.github.io/webMAN-MOD/
GNU General Public License v3.0
1.25k stars 177 forks source link

fix mounting /app_home #1074

Closed bibarub closed 1 month ago

bibarub commented 1 month ago

webMAN didn't mount /app_home correctly (it was mounting USRDIR to /app_home. i don't know the reason behind this, but it does not work at all), this commit fixes it

USRDIR-related code has been removed from both map_app_home and set_app_home, the multidisc logic from map_app_home has been commented out (it's completely broken), the conditions in set_app_home have been edited a bit

bibarub commented 1 month ago

(i only tested it on HEN 3.3.0, not sure if it works on CFW)

aldostools commented 1 month ago

@bibarub Thank you for your pull request. I have applied almost all your changes, except the removal of the multi-disc logic.

I added comments explaining how it works. Maybe you didn't get how the logic works. I tested it on CFW some years ago. Basically it requires to mount the same ISO multiple times to mount PS3_GM02, PS3_GM03, etc.

If the code is broken as you mentioned in your comments, it needs to be fixed not removed 😃

bibarub commented 1 month ago

sorry, didn't think about that at all xD. thank you for merging the code

by the way, change '18' to '11' at line 941 in include/mount/mount.h. the 7 extra bytes were used for "/USRDIR", which we don't touch anymore

also, you forgot to change the comment at line 921 in the same file

bibarub commented 1 month ago

regarding the multi-disc code don't multi-game discs still use PS3_GAME for the first game? i don't have any multi-game ISOs so i don't know how it works, just asking you to make sure

aldostools commented 1 month ago

@bibarub Thank you for your comments and for the PR. The suggested corrections were applied.

If you have additional improvements or find bugs, feel free to let me know. Best regards!!

I'm closing this PR, since I merged the changes directly .

aldostools commented 1 month ago

regarding the multi-disc code don't multi-game discs still use PS3_GAME for the first game? i don't have any multi-game ISOs so i don't know how it works, just asking you to make sure

Yes. This DisgeaTriplePlayCollectionFilelist.txt is supposed to be the directory structure from the multi-game disc "Disgea Trilogy Collection" .

I obtained it from this post https://www.psx-place.com/threads/make-multidisc-ps3-game.41758/

Current code seems to cycle only from PS3_GM01 to PS3_GM99, ignoring PS3_GAME if they exist.

I think the line 947 should be changed to gm = 01; sprintf(mpath, "%s/PS3_GAME", path); to fix the issue but I don't have a multi-game ISO to test.

Anyway this only affect noBD consoles that require mount JB games through /app_home. /dev_bdvd show multi-game discs in separated disc icons.