aldrinbaroi / mediawiki-page-attachment

Automatically exported from code.google.com/p/mediawiki-page-attachment
Other
1 stars 1 forks source link

respect cache prefix for MWCacheObjWrapper #76

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
*Background*

The built-in Mediawiki cache (at least with Memcache and CACHE_ACCEL using APC) 
prepends a cache key prefix, usually via the function wfMemcKey, which uses the 
$wgCachePrefix variable or wfWikiID(), to data stored in the cache.

Since you are directly accessing wfGetMainCache, please implement the prefix 
handling in at least those cases where the MW cache would also use prefixes.

*What is the expected output? What do you see instead?*

I'm running several Mediawikis for one project in the same cache, avoiding 
cache collisions via the native support for cache prefixes based on database 
name (wfWikiID).  The only cache entries in this storage that do not have cache 
prefixes in front of them are of the form "page_NNN" and I have tracked that 
back to the PageAttachment extension.  If I enable PageAttachment on another of 
these wikis, I could have cache collisions between wikis.

I expect the cache entries to be of the form wikiprefix:pageattachment:page_NNN.

  PageAttachment version  :  3.1.0
  MediaWiki version       :  REL1_20

Original issue reported on code.google.com by emsea...@gmail.com on 11 Jun 2013 at 10:42

GoogleCodeExporter commented 9 years ago
Hi Emsearcy:

Thank you for reporting this.  Will update code to address this issue.

Sincerely yours,

Aldrin

Original comment by Aldrin.Baroi@gmail.com on 12 Jun 2013 at 5:04

GoogleCodeExporter commented 9 years ago

Original comment by Aldrin.Baroi@gmail.com on 12 Jun 2013 at 7:44

GoogleCodeExporter commented 9 years ago
This issue was closed by revision f59ef1f8321d.

Original comment by Aldrin.Baroi@gmail.com on 13 Jun 2013 at 4:28