search

aldro61 / mmit

Regression trees for interval censored output data
https://aldro61.github.io/mmit/
GNU General Public License v3.0
7 stars 7 forks source link

mmit() #24

Closed parismita closed 6 years ago

parismita commented 6 years ago

A function to learn a MMIT model in R

aldro61 commented 6 years ago

Thanks for the PR! I will have a look at the code. We will need working to get Travis to work before we can merge. Looks like it's not finding some required R packages.

parismita commented 6 years ago

Testthat is failing here, but it was working in my pc, I solved the library issue, so what else can it be?

aldro61 commented 6 years ago

It is not testthat that is failing, but travis. You should look at the travis log to see which error messages you find.

Le 24 mai 2018 04:38 -0400, parismita notifications@github.com, a écrit :

Testthat is failing here, but it was working in my pc, I solved the library issue, so what else can it be? — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

aldro61 commented 6 years ago

I’ll be reviewing the code later today or tomorrow, so I might be able to find what’s wrong.

parismita commented 6 years ago

i looked into the log, testthat is failing for 5 cases, line where out$leftpref = 0.5

aldro61 commented 6 years ago

@parismita Let me know when you're ready for the final code review + merge

parismita commented 6 years ago

yeah! I am ready

tdhock commented 6 years ago

hi @parismita I noticed that you may be using the web interface to make changes to the code... is that true? Since the goal of GSOC is to help you learn free/ open source coding, I would recommend that you try editing the code with a real text editor (emacs or vim) or IDE (Rstudio) and then use the command line git to commit and push.

parismita commented 6 years ago

yeah using web interface but coding in rstudio, i'll try git on next commit sure.

aldro61 commented 6 years ago

@parismita @tdhock Good point! Yes, it will be better if you use git because you'll be able to assign informative names to your commits instead of "Update [...]".

aldro61 commented 6 years ago

I recommend that you add a .gitignore file in the RPackage directory to avoid commiting unwanted files.

https://github.com/github/gitignore/blob/master/R.gitignore

parismita commented 6 years ago

ok

aldro61 commented 6 years ago

All good! Merging. Congrats on your first PR :)