search

aldro61 / mmit

Regression trees for interval censored output data
https://aldro61.github.io/mmit/
GNU General Public License v3.0
7 stars 7 forks source link

Adaboost #30

Open parismita opened 6 years ago

aldro61 commented 5 years ago

I'm not sure why, but there are some problems with the c++ solver on Mac. It works perfectly on linux. I'll take a look.

aldro61 commented 5 years ago

It's fixed! I'm having a hard time pushing the changes, but I'll do it this weekend.

parismita commented 5 years ago

@aldro61 the mmitboost and mmitboost.predict has most of the code same...as we cant find the prediction value without running it, and as its iterative process hence mmitboost cant be used for prediction

So is there any way to improve this?

aldro61 commented 5 years ago

There might be some code that can be reused, maybe packaged into one or many utility functions. But before that, we should make sure that the implementation is ok.

I think that the Adaboost algorithm that you implemented is for classification. The algorithm is different for regression. Scikit-learn implements the following version (Adaboost.R2) https://www.researchgate.net/publication/2424244_Improving_Regressors_Using_Boosting_Techniques.

Note that according to this algorithm, the training data needs to be resampled with replacement before training each tree. Also, there seems to be a learning rate hyperparameter that can be tuned by the user.

parismita commented 5 years ago

ok....i'll check that and update