search

aldro61 / mmit

Regression trees for interval censored output data
https://aldro61.github.io/mmit/
GNU General Public License v3.0
7 stars 7 forks source link

scikit-learn-contrib? #31

Closed tdhock closed 5 years ago

tdhock commented 5 years ago

I wonder if it would be worth it to try to get mmit into scikit-learn-contrib?

https://github.com/scikit-learn-contrib

aldro61 commented 5 years ago

It might be a tad difficult since not all our code is sklearn compatible. For instance, the GridSearchCV class (https://github.com/aldro61/mmit/blob/master/mmit/model_selection.py#L152) is based on an sklearn class but it was modified to support pruning.

It's a good idea, but I'm not sure if it's worth it for now.

tdhock commented 5 years ago

no problem!

Welcome back to work btw! hope you enjoyed your time off!

On Tue, Oct 2, 2018 at 11:14 AM Alexandre Drouin notifications@github.com wrote:

It might be a tad difficult since not all our code is sklearn compatible. For instance, the GridSearchCV class ( https://github.com/aldro61/mmit/blob/master/mmit/model_selection.py#L152) is based on an sklearn class but it was modified to support pruning.

It's a good idea, but I'm not sure if it's worth it for now.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/aldro61/mmit/issues/31#issuecomment-426376893, or mute the thread https://github.com/notifications/unsubscribe-auth/AA478naLRp7b_a1tv3Zh-q63QNPCnURaks5ug60CgaJpZM4W-yUC .

aldro61 commented 5 years ago

Thanks Toby! Yes, it was great :) Hope that you're well! Let's meet next week if you're available.

Closing this issue for now.