search

aldro61 / mmit

Regression trees for interval censored output data
https://aldro61.github.io/mmit/
GNU General Public License v3.0
7 stars 7 forks source link

Fixed floating point precision problems in solver #6

Closed aldro61 closed 7 years ago

aldro61 commented 7 years ago

The breakpoint list was still not using 6 decimal precision, leading to solver errors in some rare cases. This has been corrected. No more solver errors when learning from the neuroblastoma data.

tdhock commented 7 years ago

I wonder if we should let the user specify the numerical tolerance parameter at run time? (rather than specifying it at compile time) I guess we can always make that change later on, if we run into any problems on other data sets.

for now I think this is ok to merge with master.