ale5000-git / tingle

Tingle - Android patcher
http://forum.xda-developers.com/showthread.php?t=3438764
GNU General Public License v3.0
160 stars 11 forks source link

don't overwrite backup file #29

Closed anarcat closed 7 years ago

anarcat commented 7 years ago

i got in this bad situation here where i patched multiple times. eventually, i wanted to back to the original non-spoofed signature, but because i ran tingle multiple times, the .backup file now refers to an already patched version tingle had downloaded from the phone...

it would seem preferable to rotate those backups or at least not overwrite them to avoid dataloss.

ale5000-git commented 7 years ago

@anarcat: Tingle do not create or touch the backup file if the new file is already patched, try it.

PS: I have an idea to improve the backup of multiple devices, stay tuned.

anarcat commented 7 years ago

hmm... well then, the restore doesn't work. i have reflashed my device with the latest CM nightly i could get my hands on and microg still believes signature spoofing is enabled. so i trusted using adb push to set the .backup file and that didn't work either... maybe there's something i'm doing wrong?

ale5000-git commented 7 years ago

@anarcat: You need to run adb root and adb remount before adb push.

PS: You also need to clean dalvik/art cache and restart the phone. PS2: I'm not sure but maybe microG cache the result of the check, have you tried to check it also with another app?

anarcat commented 7 years ago

understood, i'll try again. i have tried with other apps, not sure which one i would try....

i guess that since the .backup file is not overwritten, this is not a bug... so i'll just close this for now.

ale5000-git commented 7 years ago

@anarcat: With the latest change the backup isn't overwritten also if you patch a different phone.

PS: To test signature spoofing you can also use this.