Closed Catfriend1 closed 5 years ago
@Catfriend1: The [flake8] comments are automatic to keep code quality.
I suggest you to wait because I have intention to change a lot in the patching process to be more modular and to allow custom patching like yours.
@ale5000-git Thanks for your feedback. Waiting is okay for me, I have what I need and just liked to share the solution. Keep up your good work.
@rp57: This pull request wait my changes for plugin support that aren't ready yet.
Hello,
I've never submitted a PR before. So please tell me if I can do something better. I managed to implement the SD-card write for all apps fix from source: https://forum.xda-developers.com/android/software/guide-allow-sdcard-write-access-switch-t3593021/ I have tested the changed main.py file from tingle project under Python-Win-amd64 with Java installed > it worked. I can now write to sdcard without root and without the app asking for special permission. This is a good solution for Synchting which has a go-Component that cannot ask for permission and is instable when used in root mode.
Can you please merge my changes to main.py of tingle with an option the user being able to select if... a) wants to patch signatures b) wants to patch sd-card write for all apps c) wants to patch a)+b)
To make the code more modular, I splitted into two functions
I'll attach two changed files in ZIP:
Thanks for your help. Kind regards.
This change is![Reviewable](https://reviewable.io/review_button.svg)