ale5000-git / tingle

Tingle - Android patcher
http://forum.xda-developers.com/showthread.php?t=3438764
GNU General Public License v3.0
160 stars 11 forks source link

NameError Error #52

Open Heat84 opened 6 months ago

Heat84 commented 6 months ago

When I try to install the patch, I get the following error message: NameError: name 'true' is not defined. Did you mean: 'True'?

I tried the Needle patch first and got the same error message except the undefined word was false.

ale5000-git commented 4 months ago

Hi, could you please post the entire log and the version of Python? Without additional info I'm not sure what to reply.

Heat84 commented 4 months ago

Ok. Will do ASAP. That seems like a basic error message that a seasoned programmer would be able diagnose easily. But I'm not a programmer(yet), so what do I know.

I don't actually need this anymore because after I updated LineageOS a couple days ago, the signature spoofing part of microG started working. It's all green check marks in microG's self check now. But I'll still get the error log. Since Tingle isn't working, would there be any harm in running the script again just to get the error log? Maybe it would disable signature spoofing? Maybe since signature spoofing is working now, I wouldn't get the same error message? So maybe there's no point in trying to get the error log now?

Since Needle has the same problem except false isn't defined instead of true, however you would fix Tingle, Needle would be fixed the same way?

ale5000-git commented 4 months ago

I'm asking because in my code there isn't any full lowercased true, so I'm not really sure where it came from. Mainly I want to know what is the point that generate the error so I can look at it. If you can post the log I would appreciate it very much.

If you want to be sure just change from DEBUG_PROCESS = False to DEBUG_PROCESS = True at the line 20 of main.py and it won't do any change to the device.

Needle is similar but not completely equal and it isn't maintained from a lot of time. It is possible that a fix is similar but I can't grant it.

Heat84 commented 4 months ago

I figured out the problem. I didn't download the patch zip. I just downloaded main.py. Why is there no button that says Download Patch? Why is Download Zip at the bottom of a menu instead on the page? Of course that's not your fault. Its not your website. Then again, maybe if I was a seasoned programmer like you, the way this site works would make sense to me. Way back when I first came to download the patch, I assumed that I did need the folders, but when I couldn't see a way to download all of them at once, I assumed my initial assumption was wrong.

Well , thank you for intending to help me. And thanks for making the patch even though I didn't need it. Do you have any idea why signature spoofing mysteriously started working right after an OS update?

ale5000-git commented 4 months ago

I always neglected the readme and the documentation for the lack of time :-) I have now added a download link in the readme so it is now easier.

microG now works without Tingle because recently LineageOS has accepted to include a signature spoofing patch in their ROM (it was rejected for many years).

But Tingle is still needed for the devices that don't get updates or for the ROMs that doesn't have the patch included.