search

aleaf / pydrograph

Get and process stream flows and groundwater levels from NWIS.
Other
13 stars 11 forks source link

add ivs #5

Closed lauraschachter closed 3 years ago

lauraschachter commented 3 years ago

add instantaneous values functions to nwis module. create urls, pulls ivs, and resamples data

codecov[bot] commented 3 years ago

Codecov Report

Merging #5 into develop will increase coverage by 1.56%. The diff coverage is 86.95%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop       #5      +/-   ##
===========================================
+ Coverage    76.25%   77.82%   +1.56%     
===========================================
  Files           11       11              
  Lines          636      735      +99     
===========================================
+ Hits           485      572      +87     
- Misses         151      163      +12
Impacted Files Coverage Δ
pydrograph/nwis.py 86.05% <85.36%> (-0.28%) :arrow_down:
pydrograph/attributes.py 100.00% <100.00%> (ø)
pydrograph/tests/test_nwis.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 358ddd2...9c0527b. Read the comment docs.

aleaf commented 3 years ago

hey @lauraschachter, this looks good. Can you just add a test that covers the get_ivs and get_all_ivs methods? I think testing the latter would cover both. Thanks!