aleasoluciones / gosnmpquerier

Scalable Snmp Querier (sync/async)
MIT License
8 stars 2 forks source link

dependencies broken #5

Open miklert opened 3 years ago

miklert commented 3 years ago

gosnmpquerier depends on the github.com/soniah/gosnmp which has been moved to github/gosnmp/gosnmp and now identifies itself as a gosnmp/gosnmp package. This breaks the build process:


$ go build cmd/worker/glb_snmp_worker.go 
go: finding github.com/aleasoluciones/gosnmpquerier latest
go: finding github.com/aleasoluciones/goaleasoluciones latest
go: github.com/aleasoluciones/gosnmpquerier imports
        github.com/soniah/gosnmp: github.com/soniah/gosnmp@v1.29.0: parsing go.mod:
        module declares its path as: github.com/gosnmp/gosnmp
                but was required as: github.com/soniah/gosnmp
I believe the solution is to change the dependency to gosnmp/gosnmp
miklert commented 3 years ago

i've cloned to my gitlab with the change https://gitlab.com/mikler/gosnmpquerier dependencies to gosnmp/gosnmp, and this has worked well for me

raulvillares commented 3 years ago

Hello Mikhail,

first of all, thanks for your feedback. We had just create a branch that uses gosnmp/gosnmp instead of soniah/gosnmp.

This change has caused an automatic test to fail (in one of our private projects). We had already fixed it (it was a type validation issue). To be sure that this is the only effect, our idea is to internally use and monitor these new branch for about 2 weeks, then merge it to master.

We will close this issue after those 2 weeks (if everything runs smoothly).

Thanks again.