search

aleaxit / gmpy

General Multi-Precision arithmetic for Python 2.6+/3+ (GMP, MPIR, MPFR, MPC)
https://gmpy2.readthedocs.io/en/latest/
GNU Lesser General Public License v3.0
519 stars 86 forks source link

Remove calls of obsolete mpfr functions #300

Closed skirpichev closed 2 years ago

skirpichev commented 3 years ago

Failure: Ubuntu 16.04 doesn't have MPFR >= 4. Let me know if it does make sense to support this release.

skirpichev commented 3 years ago

Ok, I've added "#if" block.

skirpichev commented 3 years ago

@casevh, does this make sense for you?

casevh commented 2 years ago

The functions you've changed are already guarded by a version check and they are only used with MPFR v3.x. There is a lot of duplicated code but that's a different issue.

Is there a scenario where compilation fails on an old Linux distribution?

I'll test on Ubuntu 16.04 again but it was fine the last time I checked.

skirpichev commented 2 years ago

The functions you've changed are already guarded by a version check and they are only used with MPFR v3.x.

@casevh, yes. But the #192 was about removing warnings from these checks.

The only problem I see is a different sign conventions for mpfr_root() and mpfr_rootn_ui().

Is there a scenario where compilation fails on an old Linux distribution?

I doubt. For old MPFR we fallback on the old code.

skirpichev commented 2 years ago

Ok, I think this should be closed.