search

aleaxit / gmpy

General Multi-Precision arithmetic for Python 2.6+/3+ (GMP, MPIR, MPFR, MPC)
https://gmpy2.readthedocs.io/en/latest/
GNU Lesser General Public License v3.0
518 stars 86 forks source link

Fix incompatible (c.f. int) initialization of mpz from strings #382

Closed skirpichev closed 1 year ago

skirpichev commented 1 year ago

Closes #381

codecov-commenter commented 1 year ago

Codecov Report

Merging #382 (43e8de6) into master (ca7a8f2) will increase coverage by 0.00%. The diff coverage is 100.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##           master     #382   +/-   ##
=======================================
  Coverage   82.35%   82.36%           
=======================================
  Files          49       49           
  Lines       11552    11565   +13     
  Branches     2146     2149    +3     
=======================================
+ Hits         9514     9525   +11     
- Misses       2038     2040    +2
Impacted Files Coverage Δ
src/gmpy2_convert.c 100.00% <100.00%> (ø)
src/gmpy2_convert_gmp.c 74.72% <100.00%> (ø)
src/gmpy2_convert_mpc.c 81.22% <100.00%> (-0.69%) :arrow_down:
src/gmpy2_convert_mpfr.c 80.59% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

skirpichev commented 1 year ago

White space handling was moved to the GMPy_RemoveIgnoredASCII() helper (former GMPy_RemoveUnderscoreASCII()).

casevh commented 1 year ago

Thanks. Sorry about the delays in merging.

Case

skirpichev commented 1 year ago

Sorry about the delays in merging.

@casevh, no need for apologize. It's your time and thanks for investing it to the gmpy2 project. Personally, I would prefer careful review to a quick merge... (Sorry for a late answer.)