aleaxit / gmpy

General Multi-Precision arithmetic for Python 2.6+/3+ (GMP, MPIR, MPFR, MPC)
https://gmpy2.readthedocs.io/en/latest/
GNU Lesser General Public License v3.0
510 stars 86 forks source link

Misc fixes #413

Closed skirpichev closed 1 year ago

skirpichev commented 1 year ago
codecov-commenter commented 1 year ago

Codecov Report

Merging #413 (32a338d) into master (3212bcb) will increase coverage by 0.00%. The diff coverage is 100.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##           master     #413   +/-   ##
=======================================
  Coverage   83.59%   83.59%           
=======================================
  Files          49       49           
  Lines       11707    11711    +4     
  Branches     2188     2189    +1     
=======================================
+ Hits         9786     9790    +4     
  Misses       1921     1921           
Impacted Files Coverage Δ
src/gmpy2_convert_gmp.c 74.67% <100.00%> (+0.19%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

casevh commented 1 year ago

Shouldn't res be decremented after calling GMPy_MPQ_NewInit ?

skirpichev commented 1 year ago

Shouldn't res be decremented after calling GMPy_MPQ_NewInit ?

Indeed. First commit was updated to address this.

casevh commented 1 year ago

Thanks.

Case