search

aleaxit / gmpy

General Multi-Precision arithmetic for Python 2.6+/3+ (GMP, MPIR, MPFR, MPC)
https://gmpy2.readthedocs.io/en/latest/
GNU Lesser General Public License v3.0
506 stars 84 forks source link

Run Cython tests for binary wheels #463

Closed skirpichev closed 6 months ago

skirpichev commented 7 months ago

Closes #447

skirpichev commented 7 months ago

This is an incomplete version so far: MacOS wheels aren't tested yet. Also, probably we should document how users can use bundled libraries for their extensions.

codecov-commenter commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (8a39f52) 85.51% compared to head (3c86ae8) 85.51%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #463 +/- ## ======================================= Coverage 85.51% 85.51% ======================================= Files 49 49 Lines 11691 11691 Branches 2211 2211 ======================================= Hits 9998 9998 Misses 1693 1693 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

casevh commented 6 months ago

Am I inadvertently blocking progress on this PR?

skirpichev commented 6 months ago

Am I inadvertently blocking progress on this PR?

No, that's entirely my fault. Some further progress is in test-wheels-cython2 branch.

I'll try to finish this pr today, sorry for a delay.

skirpichev commented 6 months ago

Ok, now it works on MacOS too.

casevh commented 6 months ago

Looks fine. I'll merge the PR and then test with my Windows build process.

skirpichev commented 6 months ago

Hmm, this was a draft. This I think that related issue isn't solved: at least this pr lacks documentation.