aleaxit / gmpy

General Multi-Precision arithmetic for Python 2.6+/3+ (GMP, MPIR, MPFR, MPC)
https://gmpy2.readthedocs.io/en/latest/
GNU Lesser General Public License v3.0
506 stars 84 forks source link

Use PyLong_GetSign() #486

Open skirpichev opened 1 month ago

skirpichev commented 1 month ago

See https://github.com/python/cpython/pull/116561 and https://github.com/capi-workgroup/decisions/issues/19. I'm not happy with this API and it seems that discussion is ongoing. Maybe it's wise to wait some time...

skirpichev commented 1 month ago

Probably, discussion in https://github.com/capi-workgroup/decisions/issues/19 is ended. But see https://github.com/capi-workgroup/decisions/issues/29

casevh commented 4 weeks ago

Should this be merged now and then released as 2.2.0 or should this wait until 2.2.1?

skirpichev commented 4 weeks ago

Should this be merged now and then released as 2.2.0

I don't think so. https://github.com/capi-workgroup/decisions/issues/29 is open. We should wait, see also https://discuss.python.org/t/c-api-working-group-vacancy-again/56167

This pr shouldn't block 2.2 release. I'll just mark it as a draft.