search

aleaxit / gmpy

General Multi-Precision arithmetic for Python 2.6+/3+ (GMP, MPIR, MPFR, MPC)
https://gmpy2.readthedocs.io/en/latest/
GNU Lesser General Public License v3.0
506 stars 84 forks source link

2.2.0: change in tagging convention? 🤔 #488

Open kloczek opened 3 weeks ago

kloczek commented 3 weeks ago

Looks like with recent version has been changed tagging convention from 'gmpy2-togmpy2_`. Is it only mistake or from now it will be new tagging convention? I'm asking because my automation relies on exact convention on processing new release email notifications.

casevh commented 3 weeks ago

It was a mistake. What is the best option? Create a new tag with dots and leave both tags, or create the new tag and delete the old one (trying to do a rename)?

kloczek commented 3 weeks ago

Best to be hones would be just <version.with.dots> or v<version.with.dots> because in autogenerated tar ball base directory is automatically generated out of <repo-name>-<git-tag> and if in tag is used on the begging v it is skipped (to make easier branching with <version.with.dots> on v<version.with.dots> to branch some version + some critical changes).

casevh commented 3 weeks ago

Is it okay to just create a tag 2.2.0 and leave the old tag as-is? There haven't been any code changes.

skirpichev commented 3 weeks ago

Perhaps, it might be a good idea to automate release process. In the diofant project I just do git push origin v1.2.3, that's all.

kloczek commented 3 weeks ago

You can peak as well on automating procedure of creating GH release entry https://github.com/RDFLib/rdflib-sqlalchemy/issues/95 https://github.com/RDFLib/rdflib/pull/2036 https://github.com/click-contrib/sphinx-click/commit/abc31069 https://github.com/frostming/unearth/issues/14 https://github.com/jaraco/cssutils/issues/21 https://github.com/latchset/jwcrypto/pull/289 https://github.com/latchset/jwcrypto/pull/289 https://github.com/pypa/distlib/commit/98b9b89f https://github.com/pywbem/pywbem/pull/2895 https://github.com/sissaschool/elementpath/commit/bf869d9e https://github.com/sissaschool/xmlschema/commit/42ea98f2 https://github.com/sqlalchemy/sqlalchemy/commit/5e88e6e8

skirpichev commented 3 weeks ago

BTW, I'm not sure, that @casevh has required permissions for this repository...

casevh commented 3 days ago

I have tagged v2.2.1 and released on PyPi.

skirpichev commented 2 days ago

Probably, this can be closed?