alec-hs / Flaxs-Arma-Server-Tool-2

Full rebuild of my tool for installing and updating Arma 3 server with built in features for managing Steam Workshop mods.
https://forums.bohemia.net/forums/topic/220433-fast2-arma-server-and-steam-workshop-tool/
GNU General Public License v3.0
35 stars 21 forks source link

Fix Integer overflow issue with mod IDs #119

Closed wakeuphate closed 4 years ago

wakeuphate commented 4 years ago

So feel free to tell me i'm completely wrong here, as I'm really not a VB developer at all; but I was running into issues with the app tonight adding my own mod and decided to look into it myself. I noticed a few Overflow issues and it turns out it was based around the Mod IDs.

I created a workshop mod today and was given the ID 2222310639. Which is greater than the 32bit Integer max of 2147483647. Thus the app fails silently while trying to add it.

This PR converts each of those Integers to Longs which should future proof longer than I think Steam will be still using these IDs.