search

alec-kr / F1PyStats

An open-source Python3 package that provides Formula 1 data to developers.
GNU General Public License v3.0
54 stars 19 forks source link

Fix incompatible default for arguments #116

Closed youpong closed 1 year ago

youpong commented 1 year ago

Description

If an explicit value of None is allowed, the use of Optional is appropriate.

Related Issue(s)

Fixes #113

User-facing Changes

None.

Screenshots (If necessary)

None.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change

Comparison is base (e31cdf5) 100.00% compared to head (b0a0e57) 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #116 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 44 44 Lines 892 893 +1 ========================================= + Hits 892 893 +1 ``` | [Impacted Files](https://codecov.io/gh/alec-kr/F1PyStats/pull/116?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [f1pystats/f1pystats.py](https://codecov.io/gh/alec-kr/F1PyStats/pull/116?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-ZjFweXN0YXRzL2YxcHlzdGF0cy5weQ==) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

youpong commented 1 year ago

Thank you for merging it!