Closed malay5 closed 1 year ago
Please close this PR under hacktoberfest
The code functions are fine, but the checks are failing. Can someone pls. help
The indentation of the following lines is seemed to be too deep. Try making them shallower.
L.430 seems to have worked. Just one more step.
L.434 should be indented the same as L.430.
L.434 should be indented the same as L.430.
Resolved! Thanks a lot!
Can you please add hacktober label to this PR?
Can you please add hacktober label to this PR?
Good function implementation.
However, you have not added any tests to your code. You should include tests when adding a new function/method to the repo.
Please add a test file called
test_fastest_laps.py
in /package_tests, which evaluates the results of thefastest_laps
function.You can have a look at other files within the /package_tests directory, to get an idea how the tests should be written.
I have added the package tests. Can you please add hacktober label to this PR
Can you please add hacktober label to this PR?
The label will be added once the PR is accepted.
@malay5 Are you making any progress on the issue?
Update: Since this PR's author has been inactive, the PR has been succeeded by #96.
main
branch, so this PR will be closed.
Description
I have written a function to get the fastest lap for the particular year and particular round, which can be called like
fp.fastest_laps(year=2020,race_round=1)
I have also added a function, to convert the hh:mm.ss to seconds using _get_sec, as it might be needed for future enhancements.
Related Issue(s)
Fixes #76