search

alechenninger / lightblue-applications

GNU General Public License v3.0
0 stars 0 forks source link

Restructure how raw query data binding is done? #9

Closed alechenninger closed 9 years ago

alechenninger commented 9 years ago

Currently the raw query is bound via angular to a model object representing the query. This much is intuitive, but it gets complicated trying to keep the query builder and the raw model in sync. You have to keep track of what you're input is as you construct the query, but there is a large part of that lifecycle where the query is not valid to be translated into the request model. Keeping those in sync, but maintaining the "temporary state of an invalid query" while it is being constructed, is a growing source of complication.

An alternative would be to keep the two separate, and only translate when switching between views/modes -- raw and builder.

alechenninger commented 9 years ago

Looking at simplifying the model binding, and then using a filter to get rid of empty optional components

alechenninger commented 9 years ago

Filters in expressions only make sense on mustache expressions. Can still use the filter as a service though. Will try getterSetter on raw view, instead of special logic on everything else.