Gtk+ 3 stock icons missing

willemw12 commented 10 years ago

Several Gtk+ 3 stock icons are missing.

The full list: https://developer.gnome.org/gtk3/stable/gtk3-Stock-Items.html A gallery of most or all default icons: http://python-gtk-3-tutorial.readthedocs.org/en/latest/stock.html

alecive commented 9 years ago

@willemw12 can you please tell me what name I should give to those icons? Most of them have already been made. Problem is that it is very difficult for me to find out which one is the correct name I have to give to the icon(s) in order for the system to find them! I didn't find any documentation on this regard.

willemw12 commented 9 years ago

My specific issue is this:

On Linux, gtk 3.14.5. Light desktop theme Greybird with dark panel icons (configured with ./configure.sh -p #646464). Missing (stock) icons fallback to icons which I cannot see (light icons on a light desktop theme) until you mouse-over them. Some examples:

Geany, under File and Search: the Left and Right arrow icons
Gedit: Fullscreen and Leave fullscreen icons. In Preference --> Plugins: the Sort icon
icon https://developer.gnome.org/gtk3/stable/gtk3-Stock-Items.html#GTK-STOCK-GOTO-BOTTOM:CAPS

So I now found two general issues:

1) Fallback iconset is not easily configurable(?) When I change in index.theme:

Inherits=AwOkenWhite,AwOken,AwOkenDark,kAwOkenWhite,kAwOken,kAwOkenDark,ubuntu-mono-dark,gnome,hicolor

to

Inherits=AwOkenDark,gnome,hicolor

or to

Inherits=gnome,hicolor

then I can see all icons (dark icons (AwOkenDark)) or dark border icons (gnome or hicolor) on a light theme). It doesn't look not pretty, but at least it is "readable".

2) Missing stock icons In https://developer.gnome.org/gtk3/stable/gtk3-Stock-Items.html you can see that many icons have been renamed. Maybe this iconset doesn't support all the new (e.g. in gedit) and all the old (e.g. in geany) stock icon names?

Most stock icon filenames seem to be "stock-.*". Where is the name in https://developer.gnome.org/gtk3/stable/gtk3-Stock-Items.html. Some (older or unofficial stock?) names start with "gtk-" or "gnome-".

alecive commented 9 years ago

1) you're right, and for that I cannot do anything because I cannot predict any possible user choice or combination of colors/themes. Ideally whenever this set will be complete, this will be not an issue at all since FlatWoken would cover any possible icon :) 2) I agree with you. GTK3 Api is very unstable, and it is very difficult for me to track everything down in order to support both old and new software. Moreover, everything changes from one distro to another, so for example the two bugs you were referring to (gedit fullscreen and geany left/right) are not present on my ubuntu 14.04 installation.

The only way to workaround this is to target any missing icon one by one and to see if any new commit will fix the thing. So can you please make a couple of screenshots with the icons you were referring to? By doing so, I can at least have an idea of what I should do :)

willemw12 commented 9 years ago

Note on my previous comment: that Geany is using older stock icon names, is just a guess. I could be wrong.

Suggestions on point:

1) When you have only one FlatWoken iconset, not more than one (FlatWokenDark and FlatWokenLight): Similar to vim option to select font colors for a dark or light terminal theme (for example, "set background=dark"), you could (for now) have an option (-t for theme):

./configure -t dark

that generates a fixed set of icon themes:

Inherits=AwOkenDark,AwOken,AwOkenWhite,...

and/or, let the user set the fallback icon themes, which I think is a better option (-i for inherits):

./configure -i AwOkenDark,AwOken

that generates:

    Inherits=AwOkenDark,AwOken,gnome,hicolor

Or better still, later on, have FlatWokenDark and FlatWokenLight (not White). But of course you already know this, because you have already done this before.

2) Haven't seen other missing icons yet, I think. Why not, in parallel of waiting for people to report missing icons, follow the specification and try to make as many of the stock icons you can find in the specifications (Gtk2, Gtk3, maybe check older versions of the specifcations for more icons).

Yes, the specification has changed, but you can still get all (or most?) stock icon names from the specification, I think.

About different distributions: does that really matter? No. Only the different Gtk2 and Gtk3 versions matter. They list the available stock icon names for that Gtk2/3 version (found in the specification).

These are only suggestions.

alecive / FlatWoken

Gtk+ 3 stock icons missing #90