alecjacobson / computer-graphics-ray-casting

Computer Graphics Assignment about Ray Casting
30 stars 28 forks source link

Error on read_json.h #3

Closed vinaykomaravolu closed 6 years ago

vinaykomaravolu commented 6 years ago

I get this error from read_json,h when I run make in linux. I have not changed/edited/added any code! Is there a way to fix this?

computer-graphics-ray-casting/include/read_json.h:94:22: error: converting to ‘std::tuple<Eigen::Matrix<double, 3, 1, 0, 3, 1>, Eigen::Matrix<double, 3, 1, 0, 3, 1>, Eigen::Matrix<double, 3, 1, 0, 3, 1> >’ from initializer list would use explicit constructor ‘constexpr std::tuple< >::tuple(_UElements&& ...) [with _UElements = {Eigen::Matrix<double, 3, 1, 0, 3, 1>, Eigen::Matrix<double, 3, 1, 0, 3, 1>, Eigen::Matrix<double, 3, 1, 0, 3, 1>};

= void; _Elements = {Eigen::Matrix, Eigen::Matrix, Eigen::Matrix}]’ tri->corners = { ^ computer-graphics-ray-casting/include/read_json.h:121:24: error: converting to ‘std::tuple, Eigen::Matrix, Eigen::Matrix >’ from initializer list would use explicit constructor ‘constexpr std::tuple< >::tuple(_UElements&& ...) [with _UElements = {Eigen::Matrix, Eigen::Matrix, Eigen::Matrix}; = void; _Elements = {Eigen::Matrix, Eigen::Matrix, Eigen::Matrix}]’ tri->corners = {
alecjacobson commented 6 years ago

what compiler are you using?

vinaykomaravolu commented 6 years ago

This is what I get during "cmake ..".

-- The C compiler identification is GNU 5.4.0 -- The CXX compiler identification is GNU 5.4.0 -- Check for working C compiler: /usr/bin/cc -- Check for working C compiler: /usr/bin/cc -- works -- Detecting C compiler ABI info -- Detecting C compiler ABI info - done -- Detecting C compile features -- Detecting C compile features - done -- Check for working CXX compiler: /usr/bin/c++ -- Check for working CXX compiler: /usr/bin/c++ -- works -- Detecting CXX compiler ABI info -- Detecting CXX compiler ABI info - done -- Detecting CXX compile features -- Detecting CXX compile features - done -- Performing Test COMPILER_SUPPORTS_CXX11 -- Performing Test COMPILER_SUPPORTS_CXX11 - Success -- Performing Test COMPILER_SUPPORTS_CXX0X -- Performing Test COMPILER_SUPPORTS_CXX0X - Success

alecjacobson commented 6 years ago

thank you. I can reproduce this. Will push a fix shortly.

vinaykomaravolu commented 6 years ago

Thank you!

alecjacobson commented 6 years ago

Fixed in 71cf44378e3f081b5534c75a0ae089fa9cb2c080