alecjacobson / geometry-processing-introduction

Introductory assignment for Geometry Processing course
Mozilla Public License 2.0
116 stars 131 forks source link

Checks on input? #15

Closed alecjacobson closed 7 years ago

alecjacobson commented 7 years ago

From personal email:

I would have written extra code to check the mesh to see if it was manifold, find open surfaces (find holes in the mesh by checking adjacent triangle edges - see if any triangles don't share an edge topologically), overlapping vertices (within machine tolerance) and a bunch of other stuff like that, but I didn't because I didn't think that was the intent of the assignment...I should have asked earlier -- but did you want us to do all those checks for the assignment?

alecjacobson commented 7 years ago

This isn't required in the homework. In general, I'll try to be better about writing in the API what's preconditions are expected of the input and postconditions on the output. Only what's explicitly asked in the assignment will be required. (But it's never a bad idea to raise an issue here about it)

For students that don't recognize what this questions asking about, ee'll be talking a bit about non-manifold meshes etc. in today's lecture and hopefully that will clear it up.