search

aleclarson / emitter-kit

Type-safe event handling for Swift
MIT License
567 stars 71 forks source link

Swift 2.0 support #18

Closed danyalaytekin closed 9 years ago

danyalaytekin commented 9 years ago

EmitterKit does not compile with Swift 2.0, in Xcode 7 beta.

image

aleclarson commented 9 years ago

Hmm, I imagine these errors aren't that difficult to fix.

Unfortunately, I don't currently have spare time to make this update.

Perhaps someone else will come in with a pull request.

Sorry for any inconvenience this may cause you!

nubbel commented 9 years ago

I probably have time for that this week.

aleclarson commented 9 years ago

Awesome work, @nubbel. Thanks for helping out!

nubbel commented 9 years ago

@aleclarson You're very welcome! May I suggest a major version bump to 4.0, because this change is not backwards compatible?

aleclarson commented 9 years ago

@nubbel That's a good point! :smile:

danyalaytekin commented 9 years ago

1)

Thanks @aleclarson @nubbel, much appreciated.

2)

This change does break Swift 1.2 though, which is still the standard version, so I'm not sure it should have been applied to master. Some other projects are using a swift-2.0 branch.

nubbel commented 9 years ago

@danyalaytekin I share your concerns. However, I think this project is more or less stale. I don't expect many changes in the next few months. If an app requires Swift 1.2 it can target the 3.x version using CocoaPods.

danyalaytekin commented 9 years ago

@nubbel :+1: