Carthage compatibility for macOS, tvOS & watchOS

aleclarson / emitter-kit

Type-safe event handling for Swift

MIT License

567 stars 71 forks source link

Carthage compatibility for macOS, tvOS & watchOS #41

Closed SimonRice closed 6 years ago

SimonRice commented 7 years ago

This project as-is seems to be Carthage compatible for iOS. This PR adds schemes & compatibility for macOS, tvOS & watchOS.

aleclarson commented 7 years ago

Why can't Carthage use the same scheme for each platform? Is there some documentation you can point me to?

SimonRice commented 7 years ago

Thank you for looking at this.

In fact it is possible to improve this by just having one scheme - it will need to be modified & you can find out more about the changes I'm making here. I'll be more than happy to do the honours & I'll let you know if I find any stumbling blocks.

SimonRice commented 7 years ago

Feel free to give this all another review. The tests don't run in macOS (due to no UIKit for ChangeListenerTests) or watchOS (due to no XCTest), but the tests run in both tvOS & iOS.

yonaskolb commented 7 years ago

@aleclarson is this possible to get merged and into a new release? We'd like to use EmitterKit with Carthage in a tvOS app

aleclarson commented 6 years ago

We can merge this once #43 gets fixed. Are any updates necessary?