search

aleclarson / emitter-kit

Type-safe event handling for Swift
MIT License
567 stars 71 forks source link

Fix Carthage compatibility for non iOS platforms #53

Closed jdf221 closed 5 years ago

jdf221 commented 6 years ago

I kept running into this error when I tried to build for MacOS:

Failed to write to /Users/jdf2/Xcode Projects/ProjectName/Carthage/Build/Mac/EmitterKit.framework: Error Domain=NSCocoaErrorDomain Code=260 "The file “EmitterKit.framework” couldn’t be opened because there is no such file."

Found an issue over on the Carthage repo that seems to have fixed it for me: https://github.com/Carthage/Carthage/issues/1547#issuecomment-256169649

Only thing changed in this pull request is the SDKROOT values from iphoneos to an empty string.

Tested this pull request in the same project that produced the above error and it worked fine.

emirandm commented 5 years ago

I am having the same issue with SDKROOT, Perhaps we can release the change for it separate from the auto retaining listeners feature

jdf221 commented 5 years ago

Oh sorry didn’t even think about this pull request getting updated with other stuff I added.

Thanks for making a new one, gonna go ahead and close this PR.