search

aleclarson / vite-tsconfig-paths

Support for TypeScript's path mapping in Vite
MIT License
1.24k stars 43 forks source link

feat: support `jsconfig.json` files #52

Closed MichaelDeBoey closed 2 years ago

MichaelDeBoey commented 2 years ago

Closes #51

MichaelDeBoey commented 2 years ago

@aleclarson Is there anything I still need to do in order to get this one merged?

aleclarson commented 2 years ago

Are you sure the upgrade to tsconfig-paths@4.0.0 is necessary here?

Also, the VSCode docs say this:

image

So you might need to check for jsconfig.json here: https://github.com/aleclarson/vite-tsconfig-paths/blob/435077a9a9150b2ebb0f1415f3cb1018a08633ea/src/index.ts#L103-L107 …or else tsconfig-paths needs to set allowJs to true for us.

MichaelDeBoey commented 2 years ago

@aleclarson I think this one should be fine now?

aleclarson commented 2 years ago

Closing in favor of #57 since I don't have permission to push to your repo

Thanks for the contribution!

MichaelDeBoey commented 2 years ago

@aleclarson Edits by maintainers are enabled though on my branch, so you should be able to push new things 🤔

aleclarson commented 2 years ago

Must have been an issue with Codespaces :)

You'll still get credit from my PR