alecmev / trimless-gmail

Automatically shows trimmed content in Google Mail™
MIT License
15 stars 6 forks source link

Trimless doesn't work with new GMail #37

Closed ShellySachs closed 5 years ago

ShellySachs commented 6 years ago

It appears that Trimless is not working with the newly redesigned GMail. Please update soon! Thanks, Shelly

alecmev commented 6 years ago

I'll look into this at some point, but:

  1. I'm using the legacy free version of G Suite, so I don't have access to the new UI yet. It likely won't be available until the new UI becomes the default for everybody.
  2. I'm a bit busy and won't be able to tend to this for at least a few weeks.

Since I can't promise a timeline, the only thing I can suggest is to stick to the old UI for now, I'm afraid.

ShellySachs commented 6 years ago

Thanks.

Shelly Sachs shelly@sachs3.com

On Fri, Apr 27, 2018 at 10:49 AM Olegs Jeremejevs notifications@github.com wrote:

I'll look into this at some point, but:

  1. I'm using the legacy free version of G Suite, so I don't have access to the new UI yet. It likely won't be available until the new UI becomes the default for everybody.
  2. I'm a bit busy and won't be able to tend to this for at least a few weeks.

Since I can't promise a timeline, the only thing I can suggest is to stick to the old UI for now, I'm afraid.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/jeremejevs/trimless-gmail/issues/37#issuecomment-384992893, or mute the thread https://github.com/notifications/unsubscribe-auth/Ak_iJsJaqAMrbSjcPHxo5pDRAMsrKi-aks5tsy-WgaJpZM4TqfRO .

abelter commented 6 years ago

It appears this is only affecting clipped messages; trimmed content (duplicate signatures, confidentiality notices, etc) are being handled as expected.

Google removed the "vem" class from the "View entire message" link and also placed that link into a separate div. I've tested the modified code below and it is working on both the old and new gmail UIs.

$("a:contains('View entire message')").each(function() { var tmpvem = $(this); $.get(this.href, function(data) { tmpvem.parents(".a3s").children("div:first").html($('font[size=-1]', data).last().html()); }); });

alecmev commented 6 years ago

@abelter Do you wish to take a stab at this and open a PR? I'm still nowhere near having free time.

ICDeadPpl commented 6 years ago

@abelter Which line is the edit supposed to be at?

abelter commented 6 years ago

@jeremejevs My change is causing it to repeatedly reload the clipped content. Once I get past that I'll open a PR.

@ICDeadPpl Lines 58-63 of contentScript.js

kesslink commented 6 years ago

You can enable the new gmail interface on your legacy GSuite now. You need to do it from the admin-->GsuiteApps-->gmail screen. Then a new option will appear in your settings dropdown within gmail.

Your Chrome add-on is one of the most valuable time (and annoyance) savers I've ever seen. I hope you find a bit of time to update it soon.

Thank you!

ajakowenko commented 6 years ago

New Gmail is rolling out to everyone next month (July) so coming soon, this awesome extension will no longer work for anyone =(. I would seriously pay for this extension if it could get updated for new Gmail.

mcgwiz commented 6 years ago

The instructions here allowed me to successfully access the new Gmail while staying on a Legacy Free account.

alecmev commented 6 years ago

I've decided to stop maintaining this extension, sorry.

This task has been sitting in my todo list for ages now, and every time I think about it, I realize that it simply isn't worth it to me. I haven't used Trimless for several years, and I'm on Inbox instead of Gmail, since the new design is too much of a disappointment to tolerate.

I'm happy to review PRs and do the publishing. Just no actual coding, thinking or thorough testing.

ajakowenko commented 6 years ago

Is your mind changed any knowing that they're shutting down Inbox?

alecmev commented 6 years ago

@ajakowenko Welp... back to Gmail :smile: But my mind is unchanged, still not using Trimless.

ICDeadPpl commented 6 years ago

OT Here's some tips how to make Gmail more pleasant: https://www.computerworld.com/article/3305068/email/gmail-desktop-interface.html

Hawkeye56 commented 6 years ago

As of 8 October this is still affecting the new GMail and it is not possible to revert to the old version of GMail (would that it were!).

ICDeadPpl commented 5 years ago

Is there a way to make this a userscript for Greasemonkey, Tampermonkey and the likes?

alecmev commented 5 years ago

It's possible, but requires quite a few changes. Somebody would need to put in the hours, at which point they might as well just fork or take over this repo.

FortFun commented 5 years ago

jeremejevs, any chance you would consider revising trimless for Firefox to work with the new gmail? I sure do miss it's functionality, but am not experienced enough to revise.

alecmev commented 5 years ago

The fix is available in 1.10.4. Please, report here if you see any untrimmed "View entire message".

ShellySachs commented 5 years ago

Works perfectly. Brilliant!

On Thu, Nov 29, 2018 at 2:46 PM Olegs Jeremejevs notifications@github.com wrote:

The fix is available in 1.10.4. Please, report here if you see any untrimmed "View entire message".

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/jeremejevs/trimless-gmail/issues/37#issuecomment-442968027, or mute the thread https://github.com/notifications/unsubscribe-auth/Ak_iJnikiMkxEJw19HiKdJEPvTpGDQoIks5u0DlqgaJpZM4TqfRO .

FortFun commented 5 years ago

Only works sometimes for me.

On Thu, Nov 29, 2018 at 1:45 PM Olegs Jeremejevs notifications@github.com wrote:

The fix is available in 1.10.4. Please, report here if you see any untrimmed "View entire message".

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/jeremejevs/trimless-gmail/issues/37#issuecomment-442968027, or mute the thread https://github.com/notifications/unsubscribe-auth/ArVlZFeu0VP5Zi0vBSFoCaBC3X4WKd5Eks5u0DlqgaJpZM4TqfRO .

alecmev commented 5 years ago

@FortFun That must be a different problem then. Please, elaborate in a new issue.