search

alecmuffett / certificate-transparency

Automatically exported from code.google.com/p/certificate-transparency
0 stars 0 forks source link

name.py missing import, causes crash on undefined exception type, patch included #11

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
https://codereview.appspot.com/14502064

stack trace:
  File "/usr/local/Cellar/python/2.7.5/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/ct-0.1-py2.7.egg/ct/crypto/cert.py", line 297, in subject_alternative_names
    return name.parse_alternative_names(general_names)
  File "/usr/local/Cellar/python/2.7.5/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/ct-0.1-py2.7.egg/ct/crypto/name.py", line 87, in parse_alternative_names
    return [GeneralName(n) for n in asn1_alternative_names_extension]
  File "/usr/local/Cellar/python/2.7.5/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/ct-0.1-py2.7.egg/ct/crypto/name.py", line 7, in __init__
    self.__parse_name()
  File "/usr/local/Cellar/python/2.7.5/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/ct-0.1-py2.7.egg/ct/crypto/name.py", line 12, in __parse_name
    self.__parse_name_value(self.__asn1_name.getComponent())
  File "/usr/local/Cellar/python/2.7.5/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/ct-0.1-py2.7.egg/ct/crypto/name.py", line 38, in __parse_name_value
    except pyasn1_error.PyAsn1Error:
NameError: global name 'pyasn1_error' is not defined

Original issue reported on code.google.com by nickgsup...@gmail.com on 14 Oct 2013 at 1:28

GoogleCodeExporter commented 9 years ago 
Fixed in 
http://code.google.com/p/certificate-transparency/source/detail?r=1745be61e072

But I'm wondering what caused the exception path to be taken - do you have a 
test cert that triggers it?

Original comment by ekasper@google.com on 14 Oct 2013 at 6:25