search

alecmuffett / certificate-transparency

Automatically exported from code.google.com/p/certificate-transparency
0 stars 0 forks source link

RFC6962-bis: Should we flatten the MerkleTreeLeaf structure #29

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
That is, eliminate

          MerkleLeafType leaf_type;
           select (leaf_type) {
               case timestamped_entry: TimestampedEntry;
           }

and include TimestampedEntry directly.

Original issue reported on code.google.com by benl@google.com on 29 Jan 2014 at 3:28

GoogleCodeExporter commented 9 years ago 
I'm in favour.

Original comment by er...@google.com on 29 Jan 2014 at 3:32

GoogleCodeExporter commented 9 years ago 
Out of curiosity, is the argument for flattening:
    1. Greater confidence that there won't be need for new MerkleLeafTypes, or
    2. If we ever did need new MerkleLeafType types (as mentioned in "Future revisions of this protocol version may add new MerkleLeafType types."), they could be added in a later version of MerkleTreeLeaf, by reintroducing this select.

Original comment by goo...@tom-fitzhenry.me.uk on 25 Feb 2014 at 7:58

GoogleCodeExporter commented 9 years ago 
No, its because the included structure already contains a type selector, so we 
expect that we could distinguish there instead.

Original comment by benl@google.com on 26 Feb 2014 at 12:59

GoogleCodeExporter commented 9 years ago 
Migrated to http://trac.tools.ietf.org/wg/trans/trac/ticket/6.

Original comment by er...@google.com on 3 Mar 2014 at 8:37