Implementation of RFC compatible monitor (C++) w/patch

alecmuffett / certificate-transparency

Automatically exported from code.google.com/p/certificate-transparency

0 stars 0 forks source link

Implementation of RFC compatible monitor (C++) w/patch #9

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

Adds RFC compatible monitor to the C++ code base.

https://codereview.appspot.com/14205043/

As mentioned on the ct hackday this is the monitor we run as a 
proof-of-concept. Bureaucracy and other constraints have sadly delayed this 
submission a month - sorry for that :-/

Further information is found on the rietveld page.

Original issue reported on code.google.com by Oliver.W...@gmail.com on 1 Oct 2013 at 12:36

GoogleCodeExporter commented 9 years ago

Thanks. I have sent comments to the CL.

Original comment by benl@google.com on 1 Oct 2013 at 3:35

GoogleCodeExporter commented 9 years ago

Original comment by benl@google.com on 1 Oct 2013 at 3:36

GoogleCodeExporter commented 9 years ago

BTW, you don't have to fix the CL - if you don't want to, I will, but in any 
case, we do need you to agree to a CLA before we can accept the patch. I'm not 
sure which is appropriate for you, corporate:

https://developers.google.com/open-source/cla/corporate

or individual:

https://developers.google.com/open-source/cla/individual

Original comment by benl@google.com on 2 Oct 2013 at 12:36

Added labels: Type-Enhancement
Removed labels: Type-Defect

GoogleCodeExporter commented 9 years ago

I will fix some problems where I know how you want the fix to look like but we 
will have to discuss on a few comments on the code review page.

Regarding the CLA, I will have to ask which one is more appropriate and the 
answer will take a while because tomorrow is German Unification Day - most 
people will not be back to work before Monday.

Original comment by Oliver.W...@gmail.com on 2 Oct 2013 at 2:48

GoogleCodeExporter commented 9 years ago

UPDATE: Matthew took care of the CLA and it's probably already there.
Regarding the patch set - I fixed style, minor bugs, STH uniqueness in the db 
and found some problems while looking into the code, again. Therefore I'm 
currently implementing db tests. A new patch set will be submitted in the near 
future.

Original comment by Oliver.W...@gmail.com on 7 Oct 2013 at 5:29

GoogleCodeExporter commented 9 years ago

Finally I added a new patch set introducing DB tests and fixes for most 
reviewed parts. I left the comments open for you to mark them as "Done".
If I used Rietveld wrong (i.e. diffed to wrong revisions of base files) please 
tell me.

Regarding the code organization in ct.cc - are you still willing to take care 
of that?

Original comment by Oliver.W...@gmail.com on 25 Oct 2013 at 7:19

GoogleCodeExporter commented 9 years ago

Yeah. Merging now.

Original comment by benl@google.com on 29 Oct 2013 at 3:08

GoogleCodeExporter commented 9 years ago

Original comment by benl@google.com on 29 Oct 2013 at 3:08

Changed state: Started

GoogleCodeExporter commented 9 years ago

As mentioned by Matthew and agreed by you in some mail thread aside from this 
issue / patch set and not with my appropriate email address, I signed the ICLA 
- with my gmail address.

Original comment by Oliver.W...@gmail.com on 20 Dec 2013 at 1:31

GoogleCodeExporter commented 9 years ago

Committed in
https://code.google.com/p/certificate-transparency/source/detail?r=340c643b6ae7e
5aeae3036cf6d8734d039f4fc75

Original comment by ekasper@google.com on 24 Jan 2014 at 2:01

Changed state: Fixed