search

alecthomas / SublimeLinter-contrib-gometalinter

SublimeLinter plugin for gometalinter
MIT License
47 stars 13 forks source link

Fix external dependency on highlight constants #12

Closed cixtor closed 6 years ago

cixtor commented 6 years ago

SublimeLinter v4.0.0 introduced a breaking change during the refactoring of the highlight module [1] which was changed to const. This change also affected other linters like "SublimeLinter-annotations" and so we started a campaign to fix all the dependent packages here [2].

[1] https://github.com/SublimeLinter/SublimeLinter/issues/916 [2] https://github.com/SublimeLinter/SublimeLinter/issues/915

braver commented 6 years ago

Same as with golint, you have to make sure you're still compatible with SL3: https://github.com/sirreal/SublimeLinter-contrib-golint/pull/6#issuecomment-363055115

cixtor commented 6 years ago

@alecthomas I have updated this pull-request with the feedback from @braver ; feel free to merge.