search

alecthomas / SublimeLinter-contrib-gometalinter

SublimeLinter plugin for gometalinter
MIT License
47 stars 13 forks source link

Fix: simplify the calls to communicate #27

Closed asfaltboy closed 5 years ago

asfaltboy commented 5 years ago

The newest SublimeLinter API does not require setting any of these and will (or should?) do the right thing for us.

Should fix #24

alecthomas commented 5 years ago

Nice! Does it work?

asfaltboy commented 5 years ago

Yes seems to work fine for me (I'm using the fork).

By the way is it necessary to create temp dirs/files every time we lint? Perhaps we could reuse the files, or otherwise leave it to gometalint to decide somehow? Maybe I can tackle that in another PR if you don't object

alecthomas commented 5 years ago

The temp dir is created because some linters will only operate correctly on a whole package. Most of the files are hard links, so there should be very little overhead.

asfaltboy commented 5 years ago

The temp dir is normally harmless w/ regards to IO overhead; however, sublime normally gets busy fading the new directories in and out in the sidebar (causing flickering UI). I normally have to add the .gometalinter-* to project folders ignore.

If you like I could create a new issue/PR with details and a suggested solution (e.g use default tmpdir location).

alecthomas commented 5 years ago

It can't be moved to the default temporary directory, as internal imports then don't work correctly. That is what it did initially.

asfaltboy commented 5 years ago

While looking for clues on how gometalinter operates, I just seen that gometalinter is deprecated in favour of golangci/golangci-lint and there's a sublime extension, I'm gonna give it a try and see how it operates...