search

alecthomas / devtodo2

DevTodo the Second
100 stars 18 forks source link

devtodo2 creates manpage in the wrong place #24

Closed esantoro closed 8 years ago

esantoro commented 8 years ago

I just realized that installing devtodo2 fails at installing the makefile correctly:

manu@durendall:~$ file  /usr/local/share/man/man1 
/usr/local/share/man/man1: troff or preprocessor input, ASCII text
manu@durendall:~$ head -5 /usr/local/share/man/man1 
.TH todo2 1 2.2.0 "Alec Thomas <alec@swapoff.org>"
.SH "NAME"
todo2
.SH "SYNOPSIS"
.TP
manu@durendall:~$

I guess the issue is in:

install: $(TARG) $(TARG).1
    install -m755 $(TARG) $(bindir)
        install -m644 $(TARG).1 $(man1dir)

It should probably be changed to:

install: $(TARG) $(TARG).1
    install -m755 $(TARG) $(bindir)
        install -m644 $(TARG).1 $(man1dir)/$(TARG).1

Please fix.

Thanks in advance,

esantoro

alecthomas commented 8 years ago

You could have created a PR faster than typing this issue. You can edit files in the GitHub web interface and create a PR directly from the edit.