search

alecthomas / entityx

EntityX - A fast, type-safe C++ Entity-Component system
MIT License
2.22k stars 295 forks source link

Update catch from 1.0 to 1.3.2. #146

Closed iamPHEN closed 8 years ago

iamPHEN commented 8 years ago

Should fix throw in destructor mentioned in #145.

iamPHEN commented 8 years ago

Looks like a few failures w/clang and gcc linux builds. I'll take a look into these when I can.

iamPHEN commented 8 years ago

Looks like I'm hitting this error with gcc, which looks to be fixed in Catch 1.5.0:

https://github.com/philsquared/Catch/issues/593

And looks like clang needs to be updated to 3.5 to fix those issues. I can update catch to surpress the paren warnings to 1.5.0, but I'm unsure what to do about Clang, should entityx be updated for that? Do we need more travis configs (and don't build tests with clang 3.4)?

alecthomas commented 8 years ago

This can't be merged if it requires GCC 6.1. Please reopen if you can get it working across a few compilers.