alecthomas / entityx

EntityX - A fast, type-safe C++ Entity-Component system
MIT License
2.21k stars 295 forks source link

Add warning for unsupported configuration in MSVC. #248

Closed Deledrius closed 3 years ago

Deledrius commented 3 years ago

This addresses the potential silent failure of attempting to build EntityX as a shared library with MSVC, seen in #160, #186, #206, #246, and others. It is expressed as a warning instead of a fatal error to permit the "workaround" found in multiple comments on those issues.

With this warning emitted at configuration-time, it is made clear to the end-user that this is an unsupported option on their platform, saving potential time and effort diagnosing the issue or reporting it as a bug.

alecthomas commented 3 years ago

Good idea, thanks.