search

alecthomas / go_serialization_benchmarks

Benchmarks of Go serialization methods
https://alecthomas.github.io/go_serialization_benchmarks/
1.56k stars 158 forks source link

Remove invalid disclaimer from ikeapack #153

Closed ikkerens closed 3 months ago

ikkerens commented 3 months ago

I'm not sure why this comment was added, but it is not correct, ikeapack supports float32/float64 just fine, and always has.

The reason why I didn't use float64 for a field called Money is because using float for Money is not a good idea, and I was a little cheeky at the time :)

matheusd commented 3 months ago

I'm not sure why this comment was added, but it is not correct, ikeapack supports float32/float64 just fine, and always has.

In that case, IMO the serializer should be modified to actually use a float64 field in order to demonstrate that it does support it.