search

alecthomas / gometalinter

DEPRECATED: Use https://github.com/golangci/golangci-lint
MIT License
3.51k stars 267 forks source link

Tags aren't being marked as releases #523

Closed JeremyLoy closed 6 years ago

JeremyLoy commented 6 years ago

Hi,

Not sure if this is deliberate or not, but the two most recent tags were not marked as "releases" in Github, therefore goreleaser isn't being run. This prevents the newest binary versions from being installed via home-brew or some install bash script.

thsnr commented 6 years ago

It seems to me that this is because https://github.com/alecthomas/gometalinter/blob/master/.travis.yml#L26 indicates to only create a release if TRAVIS_GO_VERSION is 1.11.x, but it is actually simply 1.11.

Replacing it with ^1\.11(\.[0-9]+)?$ should work.

alecthomas commented 6 years ago

@thsnr Thanks for picking tha tup, should be fixed now.

JeremyLoy commented 6 years ago

LGTM!, thanks for the quick fix!