search

alecthomas / voluptuous

CONTRIBUTIONS ONLY: Voluptuous, despite the name, is a Python data validation library.
https://pypi.org/project/voluptuous
BSD 3-Clause "New" or "Revised" License
1.82k stars 218 forks source link

Add pytest.ini and tox.ini to sdist #487

Closed mtelka closed 11 months ago

KapJI commented 11 months ago

Can you tell why is this useful? Why don't just checkout full repo if you want to run these checks?

mtelka commented 11 months ago

I'm packaging voluptuous for OpenIndiana. During the packaging we run tests. By default we use sdists as a source for packaging and tests are run automatically. tox.ini is useful to get test dependencies too. If there is something missing somewhere we need to do some extra manual work. Of course, we can use github tarballs instead of sdist (actually we currently do exactly that), but there are two problems with github tarballs:

  1. some manual work is needed (you can see it in our python-integrate-project.conf file),
  2. github tarballs are not reliable and could change without notice, so reproducible builds are not possible.

Thank you.

KapJI commented 11 months ago

Sounds reasonable, thank you.

alecthomas commented 11 months ago

Agreed, makes sense, thanks!

spacegaier commented 11 months ago

Does it make sense to rebuild and repush the release to pypi or do we only do that for the next release (as it would introduce inconsistencies for users that already downloaded 0.14.0 as they do not have the INI files).

mtelka commented 11 months ago

I do not need new release with these ini files added only. Thanks.

alecthomas commented 11 months ago

Next release.