Only calculate hash once for Marker objects

alecthomas / voluptuous

CONTRIBUTIONS ONLY: Voluptuous, despite the name, is a Python data validation library.

https://pypi.org/project/voluptuous

BSD 3-Clause "New" or "Revised" License

1.81k stars 219 forks source link

Only calculate hash once for Marker objects #513

Closed bdraco closed 2 months ago

bdraco commented 3 months ago

before validate_mapping_before

after validate_mapping_after

bdraco commented 3 months ago

I'm letting this run over the weekend on my production Home Assistant so I can examine the cache on Monday once its run for a bit. If all still looks well, I'll mark it ready for review than

ds-cbo commented 3 months ago

@bdraco Out of curiosity a side-question: What did you do/use to make those graphs?

bdraco commented 3 months ago

They are made using cProfile and than it's converted to a callgrind file and opened in qcachegrind

More details at https://www.home-assistant.io/integrations/profiler/

bdraco commented 2 months ago

Thanks. Looking forward to this one in a production HA